Messages in this thread | | | Date | Thu, 23 Nov 2023 18:02:58 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH v6 1/2] dt-bindings: adc: add AD7173 |
| |
Yo,
This looks a lot better IMO, thanks.
On Thu, Nov 23, 2023 at 05:23:21PM +0200, mitrutzceclan wrote: > +patternProperties: > + "^channel@[0-9a-f]$": > + type: object > + $ref: adc.yaml > + unevaluatedProperties: false
> + bipolar: > + type: boolean
This should be defined in adc.yaml, so duping it here is not needed?
> +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > + - if: > + properties: > + compatible: > + not: > + contains: > + const: adi,ad7173-8 > + then: > + properties: > + refin2-supply: false > + patternProperties: > + "^channel@[0-9a-f]$": > + properties: > + adi,reference-select: > + enum: > + - refin > + - refout-avss > + - avdd
I assume you tested that this restriction works as intended?
Cheers, Conor. [unhandled content-type:application/pgp-signature] | |