Messages in this thread | | | From | Doug Anderson <> | Date | Wed, 22 Nov 2023 08:03:50 -0800 | Subject | Re: [PATCH v2] softlockup: serialized softlockup's log |
| |
Hi,
On Wed, Nov 22, 2023 at 2:02 AM <lizhe.67@bytedance.com> wrote: > > From: Li Zhe <lizhe.67@bytedance.com> > > If multiple CPUs trigger softlockup at the same time with > 'softlockup_all_cpu_backtrace=0', the softlockup's logs will appear > staggeredly in dmesg, which will affect the viewing of the logs for > developer. Since the code path for outputting softlockup logs is not > a kernel hotspot and the performance requirements for the code are > not strict, locks are used to serialize the softlockup log output to > improve the readability of the logs. > > Signed-off-by: Li Zhe <lizhe.67@bytedance.com> > --- > Changelogs: > > v1->v2: > - define the lock outside the scope of function > - add precondition 'softlockup_all_cpu_backtrace=0' in commit message > > kernel/watchdog.c | 4 ++++ > 1 file changed, 4 insertions(+)
This seems like a useful improvement to me and the code looks good.
Reviewed-by: Douglas Anderson <dianders@chromium.org>
| |