Messages in this thread | | | From | Johannes Thumshirn <> | Subject | Re: [PATCH 1/5] btrfs: rename EXTENT_BUFFER_NO_CHECK to EXTENT_BUFFER_CANCELLED | Date | Wed, 22 Nov 2023 13:57:13 +0000 |
| |
On 22.11.23 14:27, David Sterba wrote: > On Tue, Nov 21, 2023 at 08:32:30AM -0800, Johannes Thumshirn wrote: >> EXTENT_BUFFER_CANCELLED better describes the state of the extent buffer, >> namely its writeout has been cancelled. > > I've read the patches a few times and still can't see how the meaning of > 'cancelled' fits. It's about cancelling write out yes, but I don't see > anywhere explained why and why the eb is zeroed. This could be put next > to the enum definition or to function that does the main part of the > logic. You can also rename it to CANCELLED_WRITEOUT or use _ZONED_ in > the name so it's clear that it has a special purpose etc, but as it is > now I think it should be improved. >
How about EXTENT_BUFFER_ZONED_ZEROOUT? It a) indicates the buffer is zeroed out and b) only for zoned mode.
| |