Messages in this thread | | | Date | Tue, 21 Nov 2023 22:35:19 -0800 | Subject | Re: [PATCH v1 1/2] hwmon: pmbus: Add adm1281 support | From | Guenter Roeck <> |
| |
On 11/21/23 19:23, Delphine CC Chiu wrote: > Add device type support for adm1281 >
s/device type/chip/
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com> > --- > Documentation/hwmon/adm1275.rst | 8 ++++++++ > drivers/hwmon/pmbus/adm1275.c | 8 ++++++-- > 2 files changed, 14 insertions(+), 2 deletions(-) > > diff --git a/Documentation/hwmon/adm1275.rst b/Documentation/hwmon/adm1275.rst > index 804590eeabdc..47a13b56e086 100644 > --- a/Documentation/hwmon/adm1275.rst > +++ b/Documentation/hwmon/adm1275.rst > @@ -43,6 +43,14 @@ Supported chips: > > Datasheet: www.analog.com/static/imported-files/data_sheets/ADM1278.pdf > > + * Analog Devices ADM1281 > + > + Prefix: 'adm1281' > + > + Addresses scanned: - > + > + Datasheet: > +
Another undocumented / unpublished chip ?
If so, at say something like "Not publicly available".
> * Analog Devices ADM1293/ADM1294 > > Prefix: 'adm1293', 'adm1294' > diff --git a/drivers/hwmon/pmbus/adm1275.c b/drivers/hwmon/pmbus/adm1275.c > index e2c61d6fa521..979474ba6bd3 100644 > --- a/drivers/hwmon/pmbus/adm1275.c > +++ b/drivers/hwmon/pmbus/adm1275.c > @@ -18,7 +18,7 @@ > #include <linux/log2.h> > #include "pmbus.h" > > -enum chips { adm1075, adm1272, adm1275, adm1276, adm1278, adm1293, adm1294 }; > +enum chips { adm1075, adm1272, adm1275, adm1276, adm1278, adm1281, adm1293, adm1294 }; > > #define ADM1275_MFR_STATUS_IOUT_WARN2 BIT(0) > #define ADM1293_MFR_STATUS_VAUX_UV_WARN BIT(5) > @@ -362,6 +362,7 @@ static int adm1275_read_word_data(struct i2c_client *client, int page, > ret = -ENODATA; > break; > } > +
Please refrain from making cosmetic changes like this.
Thanks, Guenter
> return ret; > } >
| |