Messages in this thread | | | Date | Wed, 22 Nov 2023 11:28:43 +0000 | From | Conor Dooley <> | Subject | Re: [PATCH 2/3] riscv: Remove unused members from struct cpu_operations |
| |
On Tue, Nov 21, 2023 at 03:47:25PM -0800, Samuel Holland wrote: > name is not used anywhere at all. cpu_prepare and cpu_disable do nothing > and always return 0 if implemented. > > Signed-off-by: Samuel Holland <samuel.holland@sifive.com>
Part of me says this should be split so that it can be partially reverted whenever we grow users for these, but I doubt that the implementer of that will notice nor that anyone will remember you removed them. Certainly wouldn't object if there was a split though. I guess in general this was a case of copy-pasting stuff from arm64 that we did not yet have users for.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers, Conor. [unhandled content-type:application/pgp-signature] | |