Messages in this thread | | | Date | Wed, 22 Nov 2023 08:23:04 +0200 | From | Tony Lindgren <> | Subject | Re: [PATCH v3 3/3] serial: core: Move console character device handling from printk |
| |
* Andy Shevchenko <andriy.shevchenko@intel.com> [231121 18:00]: > On Tue, Nov 21, 2023 at 01:31:57PM +0200, Tony Lindgren wrote: > > + ret = add_preferred_console_match(name, drv->dev_name, port->line); > > + if (ret && ret != -ENOENT) > > + return ret; > > + > > + return 0; > > 2nd time and so on, perhaps deserves a helper? > > static inline int add_preferred_console...(...) > { > int ret; > > ret = add_preferred_console_match(name, drv->dev_name, port->line); > if (ret == -ENOENT) > return 0; > return ret; > > } > > ?
Yes good idea, thanks.
Tony
| |