Messages in this thread | | | Date | Wed, 22 Nov 2023 15:38:36 +0530 | Subject | Re: [PATCH v2 3/9] dt-bindings: clock: ipq5332: drop the few nss clocks definition | From | Kathiravan Thirumoorthy <> |
| |
On 11/21/2023 8:36 PM, Krzysztof Kozlowski wrote: > On 21/11/2023 15:30, Kathiravan Thirumoorthy wrote: >> In commit 0dd3f263c810 ("clk: qcom: ipq5332: enable few nssnoc clocks in > > Where is this commit coming from? > >> driver probe"), gcc_snoc_nssnoc_clk, gcc_snoc_nssnoc_1_clk, >> gcc_nssnoc_nsscc_clk are enabled in driver probe to keep it always-on. > > Implementation can change and for example bring back these clocks. Are > you going to change bindings? No, drop the patch. > > Bindings should be dropped only in a few rare cases like clocks not > available for OS or bugs.
Thanks Krzysztof. Will drop this patch in V3.
One more question to understand further. In IPQ SoCs there are bunch of coresight / QDSS clocks but coresight framework doesn't handle all clocks. Those clocks are enabled in bootloader stage itself. In such case, should I drop the clocks from both binding and driver or only from driver?
Thanks, Kathiravan.
> > Best regards, > Krzysztof >
| |