Messages in this thread | | | Date | Thu, 23 Nov 2023 09:34:57 +0800 | Subject | Re: [PATCH wireless-next 2/2] rtlwifi: rtl8821ae: phy: fix an undefined bitwise shift behavior | From | Su Hui <> |
| |
On 2023/11/23 08:41, Ping-Ke Shih wrote: > >> -----Original Message----- >> From: Dan Carpenter <dan.carpenter@linaro.org> >> Sent: Wednesday, November 22, 2023 9:02 PM >> To: Su Hui <suhui@nfschina.com> >> Cc: Ping-Ke Shih <pkshih@realtek.com>; kvalo@kernel.org; nathan@kernel.org; ndesaulniers@google.com; >> trix@redhat.com; lizetao1@huawei.com; linville@tuxdriver.com; Larry.Finger@lwfinger.net; >> linux-wireless@vger.kernel.org; linux-kernel@vger.kernel.org; llvm@lists.linux.dev; >> kernel-janitors@vger.kernel.org >> Subject: Re: [PATCH wireless-next 2/2] rtlwifi: rtl8821ae: phy: fix an undefined bitwise shift behavior >> >> Perhaps, a better way to silence the warning is to just change >> _rtl8821ae_phy_calculate_bit_shift() to not return 32 bits? Do we >> really ever pass bitmask 0? No idea... >> > I think the bitmask should not 0, so just replace _rtl8821ae_phy_calculate_bit_shift() > by __ffs(bitmask). To be safer, callers can check bitmask is not 0 before calling. Thanks for your great suggestion! I will send v2 soon.
Su Hui
| |