Messages in this thread | | | Date | Wed, 22 Nov 2023 10:51:24 -0800 | Subject | Re: [PATCH v3] ipv6: Correct/silence an endian warning in ip6_multipath_l3_keys | From | David Ahern <> |
| |
On 11/22/23 1:06 AM, Christoph Hellwig wrote: > On Wed, Nov 22, 2023 at 05:04:49PM +0800, Kunwu Chan wrote: >> Hi Christoph, >> Thanks for your reply. >> I also can't guarantee that it's the right thing to do. Just wanted to >> dispel this warning. If you have any better way, please let me know. > > The most likely reason is that it needs an endianess conversion. I > don't know the answer either, but actually spending a few minutes > trying to understand the code should allow you to find it out quickly. > > Removing a warning for it's own sake when you don't understand it is > never a good idea. >
We should be able to set flow_label to __be32 in flow_dissector_key_tags (and remove a couple ntohl).
Tom: any reason not to do that?
| |