Messages in this thread | | | Date | Wed, 22 Nov 2023 09:43:19 -0800 | Subject | Re: [PATCH v2 1/3] scsi: ufs: core: Add ufshcd_is_ufs_dev_busy() | From | Bart Van Assche <> |
| |
On 11/22/23 09:25, Bean Huo wrote: > --- a/include/ufs/ufshcd.h > +++ b/include/ufs/ufshcd.h > @@ -126,7 +126,6 @@ enum uic_link_state { > ((h)->curr_dev_pwr_mode == UFS_POWERDOWN_PWR_MODE) > #define ufshcd_is_ufs_dev_deepsleep(h) \ > ((h)->curr_dev_pwr_mode == UFS_DEEPSLEEP_PWR_MODE) > - > /* > * UFS Power management levels. > * Each level is in increasing order of power savings, except DeepSleep > @@ -1408,6 +1407,13 @@ static inline int ufshcd_vops_phy_initialization(struct ufs_hba *hba) > return 0; > } > > +static inline bool ufshcd_is_ufs_dev_busy(struct ufs_hba *hba) > +{ > + return (hba->clk_gating.active_reqs || hba->ufshcd_state != UFSHCD_STATE_OPERATIONAL || > + hba->outstanding_reqs || hba->outstanding_tasks || hba->active_uic_cmd || > + hba->uic_async_done); > +}
Since the above function is only used in drivers/ufs/core/ufshcd.c, please move it back to that source file. The public header file include/ufs/ufshcd.h is for definitions and declarations used by both the UFS driver core and the UFS driver host files.
Thanks,
Bart.
| |