Messages in this thread | | | From | Namhyung Kim <> | Date | Wed, 22 Nov 2023 09:24:30 -0800 | Subject | Re: [PATCH v1] perf MANIFEST: Add gen-sysreg for ARM SPE |
| |
Hi Oliver,
On Wed, Nov 22, 2023 at 9:05 AM Oliver Upton <oliver.upton@linux.dev> wrote: > > Hi Ian, > > On Tue, Nov 21, 2023 at 06:28:05PM -0800, Ian Rogers wrote: > > The necessary files for generating sysreg-defs.h need adding to the > > perf tool MANIFEST that lists the files for packaging the perf tool > > source code. Fix for the following: > > > > ``` > > $ make perf-tar-src-pkg > > $ tar xvf perf-6.7.0-rc2.tar > > $ cd perf-6.7.0-rc2 > > $ make -C tools/perf > > ... > > PERF_VERSION = 6.7.rc2.gc2d5304e6c64 > > make[3]: *** No rule to make target 'perf-6.7.0-rc2/arch/arm64/tools/gen-sysreg.awk', needed by 'perf-6.7.0-rc2/tools/arch/arm64/include/generated/asm/sysreg-defs.h'. Stop. > > make[2]: *** [Makefile.perf:456: arm64-sysreg-defs] Error 2 > > make[2]: *** Waiting for unfinished jobs.... > > make[1]: *** [Makefile.perf:242: sub-make] Error 2 > > make: *** [Makefile:70: all] Error 2 > > make: Leaving directory 'perf-6.7.0-rc2/tools/perf' > > ... > > ``` > > > > Fixes: e2bdd172e665 ("perf build: Generate arm64's sysreg-defs.h and add to include path") > > --- > > Note: the breakage is in Linus' tree and perf-tools, not yet in perf-tools-next. > > > > Signed-off-by: Ian Rogers <irogers@google.com> > > I had sent out fixes for both of your comments [*], no preference as to > which gets applied. So, FWIW: > > Reviewed-by: Oliver Upton <oliver.upton@linux.dev>
Thanks, I think I can pick up your patches as they came before. Namhyung
> > [*] https://lore.kernel.org/linux-perf-users/20231121192956.919380-1-oliver.upton@linux.dev/
| |