lkml.org 
[lkml]   [2023]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 22/24] swap: make swap_cluster_readahead static
    Hi Kairui,

    On Sun, Nov 19, 2023 at 11:49 AM Kairui Song <ryncsn@gmail.com> wrote:
    >
    > From: Kairui Song <kasong@tencent.com>
    >
    > Now there is no caller outside the same file, make it static.

    Seems to me too trivial/low value to justify as a standalone patch.

    Chris

    >
    > Signed-off-by: Kairui Song <kasong@tencent.com>
    > ---
    > mm/swap.h | 8 --------
    > mm/swap_state.c | 4 ++--
    > 2 files changed, 2 insertions(+), 10 deletions(-)
    >
    > diff --git a/mm/swap.h b/mm/swap.h
    > index 4402970547e7..795a25df87da 100644
    > --- a/mm/swap.h
    > +++ b/mm/swap.h
    > @@ -56,8 +56,6 @@ struct page *read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask,
    > struct page *__read_swap_cache_async(swp_entry_t entry, gfp_t gfp_mask,
    > struct mempolicy *mpol, pgoff_t ilx,
    > bool *new_page_allocated);
    > -struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t flag,
    > - struct mempolicy *mpol, pgoff_t ilx);
    > struct page *swapin_readahead(swp_entry_t entry, gfp_t flag,
    > struct vm_fault *vmf, enum swap_cache_result *result);
    > struct page *swapin_page_non_fault(swp_entry_t entry, gfp_t gfp_mask,
    > @@ -93,12 +91,6 @@ static inline void show_swap_cache_info(void)
    > {
    > }
    >
    > -static inline struct page *swap_cluster_readahead(swp_entry_t entry,
    > - gfp_t gfp_mask, struct mempolicy *mpol, pgoff_t ilx)
    > -{
    > - return NULL;
    > -}
    > -
    > static inline struct page *swapin_readahead(swp_entry_t swp, gfp_t gfp_mask,
    > struct vm_fault *vmf, enum swap_cache_result *result)
    > {
    > diff --git a/mm/swap_state.c b/mm/swap_state.c
    > index 0433a2586c6d..b377e55cb850 100644
    > --- a/mm/swap_state.c
    > +++ b/mm/swap_state.c
    > @@ -627,8 +627,8 @@ static unsigned long swapin_nr_pages(unsigned long offset)
    > * are used for every page of the readahead: neighbouring pages on swap
    > * are fairly likely to have been swapped out from the same node.
    > */
    > -struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t gfp_mask,
    > - struct mempolicy *mpol, pgoff_t ilx)
    > +static struct page *swap_cluster_readahead(swp_entry_t entry, gfp_t gfp_mask,
    > + struct mempolicy *mpol, pgoff_t ilx)
    > {
    > struct page *page;
    > unsigned long entry_offset = swp_offset(entry);
    > --
    > 2.42.0
    >
    >

    \
     
     \ /
      Last update: 2023-11-22 06:21    [W:7.825 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site