lkml.org 
[lkml]   [2023]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] tty: con3215: drop raw3215_info::ubuffer
On Tue, Nov 21, 2023 at 11:36:21AM +0100, Jiri Slaby (SUSE) wrote:
> clang-struct [1] found raw3215_info::ubuffer unused.
>
> It's actually not used since 2004 when we switched to kernel buffers.
>
> [1] https://github.com/jirislaby/clang-struct
>
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org>
> Cc: Heiko Carstens <hca@linux.ibm.com>
> Cc: Vasily Gorbik <gor@linux.ibm.com>
> Cc: Alexander Gordeev <agordeev@linux.ibm.com>
> Cc: Christian Borntraeger <borntraeger@linux.ibm.com>
> Cc: Sven Schnelle <svens@linux.ibm.com>
> Cc: linux-s390@vger.kernel.org
> ---
> drivers/s390/char/con3215.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/s390/char/con3215.c b/drivers/s390/char/con3215.c
> index 99361618c31f..34bc343dcfcc 100644
> --- a/drivers/s390/char/con3215.c
> +++ b/drivers/s390/char/con3215.c
> @@ -89,7 +89,6 @@ struct raw3215_info {
> wait_queue_head_t empty_wait; /* wait queue for flushing */
> struct timer_list timer; /* timer for delayed output */
> int line_pos; /* position on the line (for tabs) */
> - char ubuffer[80]; /* copy_from_user buffer */
> };
>
> /* array of 3215 devices structures */

Acked-by: Alexander Gordeev <agordeev@linux.ibm.com>

\
 
 \ /
  Last update: 2023-11-21 17:39    [W:0.085 / U:0.232 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site