Messages in this thread | | | Date | Tue, 21 Nov 2023 08:02:17 -0800 | From | Guenter Roeck <> | Subject | Re: [RFC v2] hwmon: (hp-wmi-sensors) Fix failure to load on EliteDesk 800 G6 |
| |
On Sun, Nov 05, 2023 at 11:20:54AM -0800, James Seo wrote: > The EliteDesk 800 G6 stores a raw WMI string within the ACPI object in its > BIOS corresponding to one instance of HPBIOS_PlatformEvents.Name. This is > evidently a valid way of representing a WMI data item as far as the Microsoft > ACPI-WMI mapper is concerned, but is preventing the driver from loading. > > This seems quite rare, but add support for such strings. Treating this as a > quirk pretty much means adding that support anyway. > > Also clean up an oversight in update_numeric_sensor_from_wobj() in which the > result of hp_wmi_strdup() was being used without error checking. > > Reported-by: Lukasz Stelmach <l.stelmach@samsung.com> > Closes: https://lore.kernel.org/linux-hwmon/7850a0bd-60e7-88f8-1d6c-0bb0e3234fdc@roeck-us.net/ > Signed-off-by: James Seo <james@equiv.tech> > Tested-by: Lukasz Stelmach <l.stelmach@samsung.com>
I get several checkpatch warnings when trying to apply this patch. Please run checkpatch --strict and fix what it reports.
Thanks, Guenter
| |