Messages in this thread | | | Date | Tue, 21 Nov 2023 05:43:05 -0800 | From | Yury Norov <> | Subject | Re: [PATCH 34/34] sh: rework ilsel_enable() |
| |
On Sat, Nov 18, 2023 at 05:15:57PM +0100, John Paul Adrian Glaubitz wrote: > Hello Yury! > > On Sat, 2023-11-18 at 07:51 -0800, Yury Norov wrote: > > Fix opencoded find_and_set_bit(), which also suppresses potential > > KCSAN warning. > > > > Signed-off-by: Yury Norov <yury.norov@gmail.com> > > --- > > arch/sh/boards/mach-x3proto/ilsel.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/sh/boards/mach-x3proto/ilsel.c b/arch/sh/boards/mach-x3proto/ilsel.c > > index f0d5eb41521a..7fadc479a80b 100644 > > --- a/arch/sh/boards/mach-x3proto/ilsel.c > > +++ b/arch/sh/boards/mach-x3proto/ilsel.c > > @@ -99,8 +99,8 @@ int ilsel_enable(ilsel_source_t set) > > } > > > > do { > > - bit = find_first_zero_bit(&ilsel_level_map, ILSEL_LEVELS); > > - } while (test_and_set_bit(bit, &ilsel_level_map)); > > + bit = find_and_set_bit(&ilsel_level_map, ILSEL_LEVELS); > > + } while (bit >= ILSEL_LEVELS); > > > > __ilsel_enable(set, bit); > > > > The subject should mention the subsystem, i.e. "sh: mach-x3proto:".
OK, will do in v2
| |