Messages in this thread | | | Date | Tue, 21 Nov 2023 11:45:11 +0530 | Subject | Re: [PATCH] iommu/amd: Set variable amd_dirty_ops to static | From | Vasant Hegde <> |
| |
On 11/20/2023 3:23 PM, Kunwu Chan wrote: > Fix the followng warning: > drivers/iommu/amd/iommu.c:67:30: warning: symbol > 'amd_dirty_ops' was not declared. Should it be static? > > This variable is only used in its defining file, so it should be static. > > Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Thanks for the fix. Looks good to me.
Reviewed-by: Vasant Hegde <vasant.hegde@amd.com>
-Vasant
> --- > drivers/iommu/amd/iommu.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iommu/amd/iommu.c b/drivers/iommu/amd/iommu.c > index fcc987f5d4ed..9f7064360828 100644 > --- a/drivers/iommu/amd/iommu.c > +++ b/drivers/iommu/amd/iommu.c > @@ -64,7 +64,7 @@ LIST_HEAD(hpet_map); > LIST_HEAD(acpihid_map); > > const struct iommu_ops amd_iommu_ops; > -const struct iommu_dirty_ops amd_dirty_ops; > +static const struct iommu_dirty_ops amd_dirty_ops; > > int amd_iommu_max_glx_val = -1; > > @@ -2635,7 +2635,7 @@ static bool amd_iommu_enforce_cache_coherency(struct iommu_domain *domain) > return true; > } > > -const struct iommu_dirty_ops amd_dirty_ops = { > +static const struct iommu_dirty_ops amd_dirty_ops = { > .set_dirty_tracking = amd_iommu_set_dirty_tracking, > .read_and_clear_dirty = amd_iommu_read_and_clear_dirty, > };
| |