Messages in this thread | | | Date | Tue, 21 Nov 2023 17:14:22 -0800 | From | Eric Biggers <> | Subject | Re: [PATCH 06/12] RISC-V: crypto: add accelerated AES-CBC/CTR/ECB/XTS implementations |
| |
On Wed, Nov 01, 2023 at 10:16:39PM -0700, Eric Biggers wrote: > > + Architecture: riscv64 using: > > + - Zvbb vector extension (XTS) > > + - Zvkb vector crypto extension (CTR/XTS) > > + - Zvkg vector crypto extension (XTS) > > + - Zvkned vector crypto extension > > Maybe list Zvkned first since it's the most important one in this context.
BTW, I'd like to extend this request to the implementation names (.cra_driver_name) and the names of the files as well. I.e., instead of:
aes-riscv64-zvkned aes-riscv64-zvkb-zvkned aes-riscv64-zvbb-zvkg-zvkned sha256-riscv64-zvkb-zvknha_or_zvknhb sha512-riscv64-zvkb-zvknhb
... we'd have:
aes-riscv64-zvkned aes-riscv64-zvkned-zvkb aes-riscv64-zvkned-zvbb-zvkg sha256-riscv64-zvknha_or_zvknhb-zvkb sha512-riscv64-zvknhb-zvkb
and similarly for the cra_driver_name fields.
I think that's much more logical. Do you agree?
- Eric
| |