lkml.org 
[lkml]   [2023]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/12] RISC-V: crypto: add accelerated AES-CBC/CTR/ECB/XTS implementations
On Wed, Nov 01, 2023 at 10:16:39PM -0700, Eric Biggers wrote:
> > + Architecture: riscv64 using:
> > + - Zvbb vector extension (XTS)
> > + - Zvkb vector crypto extension (CTR/XTS)
> > + - Zvkg vector crypto extension (XTS)
> > + - Zvkned vector crypto extension
>
> Maybe list Zvkned first since it's the most important one in this context.

BTW, I'd like to extend this request to the implementation names
(.cra_driver_name) and the names of the files as well. I.e., instead of:

aes-riscv64-zvkned
aes-riscv64-zvkb-zvkned
aes-riscv64-zvbb-zvkg-zvkned
sha256-riscv64-zvkb-zvknha_or_zvknhb
sha512-riscv64-zvkb-zvknhb

... we'd have:

aes-riscv64-zvkned
aes-riscv64-zvkned-zvkb
aes-riscv64-zvkned-zvbb-zvkg
sha256-riscv64-zvknha_or_zvknhb-zvkb
sha512-riscv64-zvknhb-zvkb

and similarly for the cra_driver_name fields.

I think that's much more logical. Do you agree?

- Eric

\
 
 \ /
  Last update: 2023-11-22 02:14    [W:0.129 / U:2.288 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site