lkml.org 
[lkml]   [2023]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dt-bindings: usb: qcom,dwc3: adjust number of interrupts on SM6125
On 2023-11-11 15:19:53, Krzysztof Kozlowski wrote:
> Qualcomm SM6125 DWC3 USB controller comes with two interrupts (verified
> with downstream/vendor code of Trinket DTSI from Xiaomi Laurel device).
> Move the qcom,sm6125-dwc3 to appropriate place in allOf:if:then blocks
> constraining interrupts.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Agreed. I believe this is what I got stuck on when trying to address the
warning over a year ago [1]. It makes sense to drop the dm_hs_phy_irq and
dp_hs_phy_irq interrupts entirely.

Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org>

[1]: https://github.com/somainline/linux/commit/b57f7fa80cb3f5cd2db3db2d79548cbf063056d9

> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> index 64043b91ffb9..3f41362b2a91 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.yaml
> @@ -375,7 +375,6 @@ allOf:
> - qcom,sdx65-dwc3
> - qcom,sdx75-dwc3
> - qcom,sm4250-dwc3
> - - qcom,sm6125-dwc3
> - qcom,sm6350-dwc3
> - qcom,sm8150-dwc3
> - qcom,sm8250-dwc3
> @@ -408,6 +407,7 @@ allOf:
> - qcom,msm8996-dwc3
> - qcom,msm8998-dwc3
> - qcom,sm6115-dwc3
> + - qcom,sm6125-dwc3
> then:
> properties:
> interrupts:
> --
> 2.34.1
>

\
 
 \ /
  Last update: 2023-11-21 22:22    [W:0.027 / U:4.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site