Messages in this thread | | | Date | Tue, 21 Nov 2023 13:04:06 -0800 | From | Saeed Mahameed <> | Subject | Re: [PATCH V3 5/5] misc: mlx5ctl: Add umem reg/unreg ioctl |
| |
On 21 Nov 12:44, Jakub Kicinski wrote: >On Mon, 20 Nov 2023 23:06:19 -0800 Saeed Mahameed wrote: >> high frequency diagnostic counters > >So is it a debug driver or not a debug driver? >
High frequency _diagnostic_ counters are a very useful tool for debugging a high performance chip. So yes this is for diagnostics/debug.
>Because I'm pretty sure some people want to have access to high freq >counters in production, across their fleet. What's worse David Ahern >has been pitching a way of exposing device counters which would be >common across netdev. >
This is not netdev, this driver is to support ConnectX chips and SoCs with any stack, netdev/rdma/vdpa/virtio and internal chip units and acceleration engines, add to that ARM core diagnostics in case of Blue-Field DPUs.
I am not looking for counting netdev ethernet packets in this driver.
I am also pretty sure David will also want an interface to access other than netdev counters, to get more visibility on how a specific chip is behaving.
>Definite nack on this patch.
Based on what ?
| |