lkml.org 
[lkml]   [2023]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] zstd: Backport Huffman speed improvement from upstream
Date


> On Nov 21, 2023, at 3:12 PM, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>
> !-------------------------------------------------------------------|
> This Message Is From an External Sender
>
> |-------------------------------------------------------------------!
>
> On Tue, 21 Nov 2023 at 11:59, Nick Terrell <terrelln@meta.com> wrote:
>>
>> W.r.t. do { } while (0), our older Visual Studios CI jobs failed on the
>> do { } while (0) macros, because it complained about constant false
>> branches.
>
> Wow. That is some truly incompetent compiler people.
>
> I mean, really. As in "Why would you ever use that kind of garbage"
> incompetence.
>
> Honestly, any coding rule that includes "don't use the do-while-zero
> construct" is actively broken shit.
>
> Please just fix your upstream rules. Because they are incredible garbage.

Yeah, that’s the plan. Visual Studios fixed that compiler bug in VS2015 [0],
so we should be safe to migrate to safer macros. I’m going through and
doing that now, and will backport that to the kernel on top of this series.

[0] https://stackoverflow.com/a/36658783

> Linus

\
 
 \ /
  Last update: 2023-11-21 21:36    [W:0.045 / U:3.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site