| Date | Tue, 21 Nov 2023 11:49:01 -0600 | Subject | Re: [PATCH 16/17] tty: srmcons: switch need_cr to bool | From | Richard Henderson <> |
| |
On 11/21/23 03:22, Jiri Slaby (SUSE) wrote: > 'need_cr' is a flag, so type it properly to be a 'bool'. Move the > declaration into the loop too. That ensures the variable is initialized > properly even if the code was moved somehow. > > Signed-off-by: Jiri Slaby (SUSE) <jirislaby@kernel.org> > Cc: Richard Henderson <richard.henderson@linaro.org> > Cc: Ivan Kokshaysky <ink@jurassic.park.msu.ru> > Cc: Matt Turner <mattst88@gmail.com> > Cc: linux-alpha@vger.kernel.org > --- > arch/alpha/kernel/srmcons.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
|