Messages in this thread | | | Date | Tue, 21 Nov 2023 08:29:15 +0100 | From | "Arnd Bergmann" <> | Subject | Re: [PATCH 2/4] lib: move pci-specific devres code to drivers/pci/ |
| |
On Mon, Nov 20, 2023, at 22:59, Philipp Stanner wrote: > The pcim_*() functions in lib/devres.c are guarded by an #ifdef > CONFIG_PCI and, thus, don't belong to this file. They are only ever used > for pci and not generic infrastructure. > > Move all pcim_*() functions in lib/devres.c to drivers/pci/devres.c > > Suggested-by: Danilo Krummrich <dakr@redhat.com> > Signed-off-by: Philipp Stanner <pstanner@redhat.com> > --- > drivers/pci/Makefile | 2 +- > drivers/pci/devres.c | 207 ++++++++++++++++++++++++++++++++++++++++++ > lib/devres.c | 208 +------------------------------------------
Since you are moving the pci_iomap() code into drivers/pci/ already, I'd suggest merging this one into the same file and keep the two halves of this interface together.
Arnd
| |