Messages in this thread | | | Date | Mon, 20 Nov 2023 09:19:46 -0800 | Subject | Re: [PATCH v3 2/2] watchdog: mediatek: mt7988: add wdt support | From | Guenter Roeck <> |
| |
On 11/14/23 09:04, Daniel Golle wrote: > Add support for watchdog and reset generator unit of the MediaTek > MT7988 SoC. > > Signed-off-by: Daniel Golle <daniel@makrotopia.org> > --- > v3: fix wrong function parameter name in kernel-doc comment > v2: call new toprgu_reset_sw_en_unlocked from toprgu_reset_update while > holding lock. > > drivers/watchdog/mtk_wdt.c | 40 ++++++++++++++++++++++++++++++++++++++ > 1 file changed, 40 insertions(+) > > diff --git a/drivers/watchdog/mtk_wdt.c b/drivers/watchdog/mtk_wdt.c > index b2330b16b497a..3b4ee7185feed 100644 > --- a/drivers/watchdog/mtk_wdt.c > +++ b/drivers/watchdog/mtk_wdt.c > @@ -58,6 +58,8 @@ > #define WDT_SWSYSRST 0x18U > #define WDT_SWSYS_RST_KEY 0x88000000 > > +#define WDT_SWSYSRST_EN 0xfc > + > #define DRV_NAME "mtk-wdt" > #define DRV_VERSION "1.0" > > @@ -71,10 +73,12 @@ struct mtk_wdt_dev { > struct reset_controller_dev rcdev; > bool disable_wdt_extrst; > bool reset_by_toprgu; > + bool has_swsysrst_en; > }; > > struct mtk_wdt_data { > int toprgu_sw_rst_num; > + bool has_swsysrst_en; > }; > > static const struct mtk_wdt_data mt2712_data = { > @@ -89,6 +93,11 @@ static const struct mtk_wdt_data mt7986_data = { > .toprgu_sw_rst_num = MT7986_TOPRGU_SW_RST_NUM, > }; > > +static const struct mtk_wdt_data mt7988_data = { > + .toprgu_sw_rst_num = 24,
Kind of odd to have this defined locally, while the others are in include files, but not worth arguing about. Please make it a define at the top of the file, though.
Thanks, Guenter
| |