Messages in this thread | | | Date | Mon, 20 Nov 2023 09:04:36 +0200 | From | Louis Peens <> | Subject | Re: [PATCH] nfp: flower: Added pointer check and continue. |
| |
On Sat, Nov 18, 2023 at 08:22:07PM -0800, Jakub Kicinski wrote: > On Fri, 17 Nov 2023 16:27:17 +0200 Louis Peens wrote: > > > acti_netdevs = kmalloc_array(entry->slave_cnt, > > > sizeof(*acti_netdevs), GFP_KERNEL); > > > > > Unnecessary new line, please remove it. > There should be no empty lines between call and error check. > > > > + if (!acti_netdevs) { > > > + schedule_delayed_work(&lag->work, NFP_FL_LAG_DELAY); > > > + continue; > > > + } > > > + > > Thanks for reporting this Denis, it definitely seems to be an oversight. > > Would you mind adding a 'nfp_flower_cmsg_warn' here as well, so that > > this case does not go undetected? Maybe something like "cannot > > allocate memory for group processing" can work. > > There's a checkpatch check against printing warnings on allocation > failures. Kernel will complain loudly on OOM, anyway, there's no need > for a local print. Ah, thanks Jakub, I did not know that this is frowned upon. But I have not thought about OOM - it would indeed not be a silent failure.
In that case I would be quite happy to add my Ack to v2 with the newline comment addressed. > -- > pw-bot: cr
| |