lkml.org 
[lkml]   [2023]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] hisi_acc_vfio_pci: Update migration data pointer correctly on saving/resume
On Mon, Nov 20, 2023 at 09:14:06AM +0000, Shameer Kolothum wrote:
> When the optional PRE_COPY support was added to speed up the device
> compatibility check, it failed to update the saving/resuming data
> pointers based on the fd offset. This results in migration data
> corruption and when the device gets started on the destination the
> following error is reported in some cases,
>
> [ 478.907684] arm-smmu-v3 arm-smmu-v3.2.auto: event 0x10 received:
> [ 478.913691] arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000310200000010
> [ 478.919603] arm-smmu-v3 arm-smmu-v3.2.auto: 0x000002088000007f
> [ 478.925515] arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000000000000000
> [ 478.931425] arm-smmu-v3 arm-smmu-v3.2.auto: 0x0000000000000000
> [ 478.947552] hisi_zip 0000:31:00.0: qm_axi_rresp [error status=0x1] found
> [ 478.955930] hisi_zip 0000:31:00.0: qm_db_timeout [error status=0x400] found
> [ 478.955944] hisi_zip 0000:31:00.0: qm sq doorbell timeout in function 2
>
> Fixes: d9a871e4a143 ("hisi_acc_vfio_pci: Introduce support for PRE_COPY state transitions")
> Signed-off-by: Shameer Kolothum <shameerali.kolothum.thodi@huawei.com>
> ---
> drivers/vfio/pci/hisilicon/hisi_acc_vfio_pci.c | 7 +++++--
> 1 file changed, 5 insertions(+), 2 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason

\
 
 \ /
  Last update: 2023-11-20 15:30    [W:0.320 / U:0.196 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site