Messages in this thread | | | Date | Mon, 20 Nov 2023 09:12:49 +0100 | From | Neil Armstrong <> | Subject | Re: [PATCH v2 2/8] arm64: dts: qcom: add initial SM8650 dtsi |
| |
On 18/11/2023 01:21, Konrad Dybcio wrote: > On 6.11.2023 09:39, Neil Armstrong wrote: >> Add initial DTSI for the Qualcomm SM8650 platform, >> only contains nodes which doesn't depend on interconnect. >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- > Just a couple nits > > [...] > >> + cpu2-bottom-thermal { >> + polling-delay-passive = <0>; >> + polling-delay = <0>; >> + thermal-sensors = <&tsens0 6>; >> + >> + trips { >> + trip-point0 { >> + temperature = <90000>; >> + hysteresis = <2000>; >> + type = "passive"; >> + }; >> + >> + trip-point1 { >> + temperature = <95000>; >> + hysteresis = <2000>; >> + type = "passive"; >> + }; >> + >> + cpu-critical { > indentation > >> + temperature = <110000>; >> + hysteresis = <1000>; >> + type = "critical"; >> + }; >> + }; >> + }; > [...] >> + >> + nsphmx-0-thermal { >> + polling-delay-passive = <10>; >> + polling-delay = <0>; >> + thermal-sensors = <&tsens2 8>; >> + >> + trips { >> + thermal-engine-config { >> + temperature = <125000>; >> + hysteresis = <1000>; >> + type = "passive"; >> + }; >> + >> + thermal-hal-config { >> + temperature = <125000>; >> + hysteresis = <1000>; >> + type = "passive"; >> + }; > The two above nodes (which are repeated under many tzones) sound made up > just to be consumed by a bunch of android binaries > > Or at least the second one, maybe "thermal engine" is some hw/fw part? > >> + >> + reset-mon-config { > "reset mon" is not a very enticing name either.. > >> + temperature = <115000>; >> + hysteresis = <5000>; >> + type = "passive"; >> + }; >> + >> + junction-config { > ...which leads me to believe only this one is meaningful > > same goes for all tzones that have a similar mess :/ >> + temperature = <95000>; >> + hysteresis = <5000>; >> + type = "passive"; >> + };
I already did a big cleanep, will clean even further!
Thx, Neil
> > Konrad
| |