Messages in this thread | | | Date | Mon, 20 Nov 2023 08:06:33 +0100 | Subject | Re: [PATCH 2/2] dt-bindings: PCI: qcom: correct clocks for SC8180x and SM8150 | From | Krzysztof Kozlowski <> |
| |
On 16/11/2023 07:05, Manivannan Sadhasivam wrote: > On Sun, Nov 12, 2023 at 07:45:57PM +0100, Krzysztof Kozlowski wrote: >> PCI node in Qualcomm SC8180x DTS has 8 clocks, while one on SM8150 has 7 >> clocks: >> >> sc8180x-primus.dtb: pci@1c00000: 'oneOf' conditional failed, one must be fixed: >> ['pipe', 'aux', 'cfg', 'bus_master', 'bus_slave', 'slave_q2a', 'ref', 'tbu'] is too short >> >> sm8150-hdk.dtb: pci@1c00000: 'oneOf' conditional failed, one must be fixed: >> ['pipe', 'aux', 'cfg', 'bus_master', 'bus_slave', 'slave_q2a', 'ref', 'tbu'] is too short > > This error says that SM8150 has 8 clocks defined in DT, but it has only 7. I'm > confused.
I think I pasted wrong error. I'll fix in v2.
> >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Anyway, the patch looks good to me. > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >
Thanks.
Best regards, Krzysztof
| |