Messages in this thread | | | Date | Mon, 20 Nov 2023 09:11:35 +0100 | From | Neil Armstrong <> | Subject | Re: [PATCH v2 7/8] arm64: dts: qcom: sm8650-mtp: add interconnect dependent device nodes |
| |
On 18/11/2023 01:25, Konrad Dybcio wrote: > On 6.11.2023 09:39, Neil Armstrong wrote: >> Now interconnect dependent devices are added in sm8650 DTSI, >> now enable more devices for the Qualcomm SM8650 MTP board: >> - PCIe >> - Display >> - DSPs >> - SDCard >> - UFS >> - USB role switch with PMIC Glink >> >> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >> --- > Little nits: > > [...] > >> &tlmm { >> gpio-reserved-ranges = <32 8>; >> + >> + sde_dsi_active: sde-dsi-active-state { > Dmitry voiced concerns about having the "SDE_" part here lately > is it part of the actual pin name (in the schematic)?
Indeed, names and DISP0_RESET_N and MDP_VSYNC, will rename.
> > [...] > >> >> &usb_1_dwc3 { >> - dr_mode = "peripheral"; >> + dr_mode = "otg"; > Isn't that the default?
Without PMIC GLINK/UCSI, there's no mode switch source, so otg is not possible, and bootloader leaves the PMIC power state in peripheral mode.
On the other side with the next patch, we add pmic-glink and we add "usb-role-switch" making it switchable.
Neil
> > Konrad
| |