Messages in this thread | | | Date | Mon, 20 Nov 2023 09:27:42 +0100 | From | Neil Armstrong <> | Subject | Re: [PATCH v2 2/6] dt-bindings: pwm: amlogic: add new compatible for meson8 pwm type |
| |
Hi Rob,
On 19/11/2023 17:05, Rob Herring wrote: > > On Fri, 17 Nov 2023 13:59:12 +0100, Jerome Brunet wrote: >> Add a new compatible for the pwm found in the meson8 to sm1 Amlogic SoCs. >> >> The previous clock bindings for these SoCs described the driver and not the >> HW itself. The clock provided was used to set the parent of the input clock >> mux among the possible parents hard-coded in the driver. >> >> The new bindings allows to describe the actual clock inputs of the PWM in >> DT, like most bindings do, instead of relying of hard-coded data. >> >> The new bindings make the old one deprecated. >> >> There is enough experience on this HW to know that the PWM is exactly the >> same all the supported SoCs. There is no need for a per-SoC compatible. >> >> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com> >> --- >> .../devicetree/bindings/pwm/pwm-amlogic.yaml | 36 +++++++++++++++++-- >> 1 file changed, 34 insertions(+), 2 deletions(-) >> > > Reviewed-by: Rob Herring <robh@kernel.org> >
I'm puzzled, isn't it recommended to have a per-soc compatible now ?
I thought something like: - items: - enum: - amlogic,gxbb-pwm - amlogic,axg-pwm - amlogic,g12a-pwm - const: amlogic,pwm-v1
should be preferred instead of a single amlogic,meson8-pwm-v2 ?
Neil
| |