Messages in this thread | | | Date | Mon, 20 Nov 2023 09:57:27 +0100 | Subject | Re: [PATCH] ASoC: mediatek: mt8186: trivial: align code | From | AngeloGioacchino Del Regno <> |
| |
Il 17/11/23 17:09, Eugen Hristev ha scritto: > No functionality change, squash some lines and align parameters for > function prototypes to 80 chars. >
Please use scripts/get_maintainer.pl to get the correct recipients list.
> Signed-off-by: Eugen Hristev <eugen.hristev@collabora.com> > --- > sound/soc/mediatek/mt8186/mt8186-afe-control.c | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > > diff --git a/sound/soc/mediatek/mt8186/mt8186-afe-control.c b/sound/soc/mediatek/mt8186/mt8186-afe-control.c > index 55edf6374578..dda648c1e8f8 100644 > --- a/sound/soc/mediatek/mt8186/mt8186-afe-control.c > +++ b/sound/soc/mediatek/mt8186/mt8186-afe-control.c > @@ -181,7 +181,8 @@ static unsigned int pcm_rate_transform(struct device *dev, unsigned int rate) > return MTK_AFE_PCM_RATE_48K; > } > > -unsigned int mt8186_tdm_relatch_rate_transform(struct device *dev, unsigned int rate) > +unsigned int mt8186_tdm_relatch_rate_transform(struct device *dev, > + unsigned int rate)
That's not needed, 86 columns is ok.
> { > switch (rate) { > case 8000: > @@ -222,7 +223,8 @@ unsigned int mt8186_tdm_relatch_rate_transform(struct device *dev, unsigned int > return MTK_AFE_TDM_RELATCH_RATE_48K; > } > > -unsigned int mt8186_rate_transform(struct device *dev, unsigned int rate, int aud_blk) > +unsigned int mt8186_rate_transform(struct device *dev, unsigned int rate, > + int aud_blk)
Same here, not needed.
> { > switch (aud_blk) { > case MT8186_DAI_PCM: > @@ -234,14 +236,13 @@ unsigned int mt8186_rate_transform(struct device *dev, unsigned int rate, int au > } > } > > -int mt8186_dai_set_priv(struct mtk_base_afe *afe, int id, int priv_size, const void *priv_data) > +int mt8186_dai_set_priv(struct mtk_base_afe *afe, int id, int priv_size, > + const void *priv_data)
ditto.
> { > struct mt8186_afe_private *afe_priv = afe->platform_priv; > void *temp_data; > > - temp_data = devm_kzalloc(afe->dev, > - priv_size, > - GFP_KERNEL); > + temp_data = devm_kzalloc(afe->dev, priv_size, GFP_KERNEL);
The only change I agree on is this one... but I don't know if it's even worth making a commit for just this...
Regards, Angelo
| |