lkml.org 
[lkml]   [2023]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver bindings
Date
> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Sent: Wednesday, November 15, 2023 8:18 PM
> To: Delphine_CC_Chiu/WYHQ/Wiwynn <Delphine_CC_Chiu@wiwynn.com>;
> Conor Dooley <conor@kernel.org>
> Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Guenter Roeck
> <linux@roeck-us.net>; Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley <conor+dt@kernel.org>;
> Jonathan Corbet <corbet@lwn.net>; linux-i2c@vger.kernel.org;
> linux-hwmon@vger.kernel.org; devicetree@vger.kernel.org;
> linux-kernel@vger.kernel.org; linux-doc@vger.kernel.org
> Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286 driver
> bindings
>
> Security Reminder: Please be aware that this email is sent by an external
> sender.
>
> On 15/11/2023 09:38, Delphine_CC_Chiu/WYHQ/Wiwynn wrote:
> >> -----Original Message-----
> >> From: Conor Dooley <conor@kernel.org>
> >> Sent: Friday, November 10, 2023 1:10 AM
> >> To: Delphine_CC_Chiu/WYHQ/Wiwynn
> <Delphine_CC_Chiu@wiwynn.com>
> >> Cc: patrick@stwcx.xyz; Jean Delvare <jdelvare@suse.com>; Guenter
> >> Roeck <linux@roeck-us.net>; Rob Herring <robh+dt@kernel.org>;
> >> Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> >> <conor+dt@kernel.org>; Jonathan Corbet <corbet@lwn.net>;
> >> linux-i2c@vger.kernel.org; linux-hwmon@vger.kernel.org;
> >> devicetree@vger.kernel.org; linux-kernel@vger.kernel.org;
> >> linux-doc@vger.kernel.org
> >> Subject: Re: [PATCH v4 1/2] dt-bindings: hwmon: Add lltc ltc4286
> >> driver bindings
> >>
> >> On Thu, Nov 09, 2023 at 09:49:45AM +0800, Delphine CC Chiu wrote:
> >>> Add a device tree bindings for ltc4286 device.
> >>>
> >>> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@Wiwynn.com>
> >>>
> >>> Changelog:
> >>> v4 - Revise some inappropriate writing in yaml file
> >>> v3 - Revise adi,vrange-select-25p6 to adi,vrange-low-enable
> >>> v2 - Revise vrange_select_25p6 to adi,vrange-select-25p6
> >>> - Add type for adi,vrange-select-25p6
> >>> - Revise rsense-micro-ohms to shunt-resistor-micro-ohms
> >>
> >> Your changelog should be below the --- line.
> >
> > We will add --- line on our changelog.
> >
> >> You also omitted the tag I left on the previous version.
> >
> > Could you point out the exact places that we omit?
>
> Open the previous email and read it fully. Did you or did you not get a tag?

We realize the meaning of tag after survey.
We will add tag in commit message.
Thanks.

>
> > Thanks.
> >
> >> With the changelog fixed:
> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
> Best regards,
> Krzysztof

\
 
 \ /
  Last update: 2023-11-21 03:28    [W:0.086 / U:0.396 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site