lkml.org 
[lkml]   [2023]   [Nov]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 12/16] arm64: dts: qcom: sm8550-aim300: enable PMIC Volume and Power buttons
From


在 11/17/2023 6:32 PM, Krzysztof Kozlowski 写道:
> On 17/11/2023 11:18, Tengfei Fan wrote:
>> The Volume Down & Power buttons are controlled by the PMIC via the PON
>> hardware, and the Volume Up is connected to a PMIC gpio.
>>
>> Enable the necessary hardware and setup the GPIO state for the Volume Up
>> gpio key.
>>
>> Signed-off-by: Tengfei Fan <quic_tengfan@quicinc.com>
>> ---
>
> No, really, necessary hardware? So why it is missing in the previous patch?
>
> Stop useless splitting of work which is done. You cannot have "release
> late, release often". The rule is: "release early, release often".
>
> NAK.
>
> Best regards,
> Krzysztof
>

Hi Krzysztof,
In next version patch series, I'm going to combine all the splited
functions into one patch.

--
Thx and BRs,
Tengfei Fan

\
 
 \ /
  Last update: 2023-11-21 02:04    [W:0.144 / U:0.092 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site