Messages in this thread | | | Date | Thu, 2 Nov 2023 08:40:10 +0200 | Subject | Re: [PATCH 04/10] drm/tidss: Move reset to the end of dispc_init() | From | Tomi Valkeinen <> |
| |
On 01/11/2023 15:57, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Wed, Nov 01, 2023 at 11:17:41AM +0200, Tomi Valkeinen wrote: >> We do a DSS reset in the middle of the dispc_init(). While that happens >> to work now, we should really make sure that e..g the fclk, which is >> acquired only later in the function, is enabled when doing a reset. This >> will be handled in a later patch, but for now, let's move the >> dispc_softreset() call to the end of dispc_init(), which is a sensible >> place for it anyway. >> >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > But do I understand correctly that the device isn't powered up at this > point ? That seems problematic.
Indeed. It's fixed later in this series.
> I'm also not sure why we need to reset the device at probe time.
That's the usual place to do a reset, to make sure the HW is in a known state, is it not? Where would you place it?
Tomi
| |