Messages in this thread | | | Date | Thu, 2 Nov 2023 14:32:30 +0100 | Subject | Re: [PATCH RFC 2/8] arm64: dts: qcom: add initial SM8650 dtsi | From | Konrad Dybcio <> |
| |
On 02/11/2023 11:54, Neil Armstrong wrote: > On 25/10/2023 11:01, Konrad Dybcio wrote: >> >> >> On 10/25/23 09:47, Neil Armstrong wrote: >>> Add initial DTSI for the Qualcomm SM8650 platform, >>> only contains nodes which doesn't depend on interconnect. >>> >>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org> >>> ---[...] >> >>> + CLUSTER_SLEEP_1: cluster-sleep-1 { >>> + compatible = "domain-idle-state"; >>> + arm,psci-suspend-param = <0x4100c344>; >> I think this parameter signals the AOSS to attempt system >> suspend and CLUSTER_SLEEP is a shallower, separate state. > > OK, so downstream call this state "APSS_OFF" and the other state > calling 0x41000044 "CLUSTER_PWR_DN"Well, the name APSS_OFF suggests that all clusters go offline so that would be a bit more complex than a simple "cut power to this cluster"
> On sm8[345]0 and qdu1000/sm4450 there's both states called > CLUSTER_SLEEP_0 and CLUSTER_SLEEP_1, > and referenced into CLUSTER_PD cluster power domain. > > I assume this is the same as SM8550, so what's the issue ? It's just that we've been naming it in the most generic way possible and that it could be more descriptive, especially given its correlation with different things
Konrad
| |