lkml.org 
[lkml]   [2023]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v7 3/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver
Hi Jim,

thanks for your patch!

I saw that Andy already provided some good feedback but couldn't help
but to notice this:

On Wed, Nov 1, 2023 at 3:52 AM Jim Liu <jim.t90615@gmail.com> wrote:

> Changes for v6:
> - Remove bus-frequency property set
> - Use GPIO_GENERIC
(...)
> +config GPIO_NPCM_SGPIO
> + bool "Nuvoton SGPIO support"
> + depends on (ARCH_NPCM || COMPILE_TEST) && OF_GPIO
> + select GPIO_GENERIC

You select GPIO_GENERIC but you don't actually use it.
If you were using it, your code would be calling bgpio_init()
and it does not.

Yours,
Linus Walleij

\
 
 \ /
  Last update: 2023-11-02 13:50    [W:0.333 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site