Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 2 Nov 2023 13:49:09 +0100 | Subject | Re: [PATCH v7 3/3] gpio: nuvoton: Add Nuvoton NPCM sgpio driver |
| |
Hi Jim,
thanks for your patch!
I saw that Andy already provided some good feedback but couldn't help but to notice this:
On Wed, Nov 1, 2023 at 3:52 AM Jim Liu <jim.t90615@gmail.com> wrote:
> Changes for v6: > - Remove bus-frequency property set > - Use GPIO_GENERIC (...) > +config GPIO_NPCM_SGPIO > + bool "Nuvoton SGPIO support" > + depends on (ARCH_NPCM || COMPILE_TEST) && OF_GPIO > + select GPIO_GENERIC
You select GPIO_GENERIC but you don't actually use it. If you were using it, your code would be calling bgpio_init() and it does not.
Yours, Linus Walleij
| |