Messages in this thread | | | From | Naresh Solanki <> | Date | Thu, 2 Nov 2023 17:35:42 +0530 | Subject | Re: [PATCH] drivers/regulator: Notify sysfs about status changes |
| |
Hi Mark,
On Thu, 5 Oct 2023 at 22:30, Mark Brown <broonie@kernel.org> wrote: > > On Thu, Oct 05, 2023 at 03:30:58PM +0200, Naresh Solanki wrote: > > > static int _notifier_call_chain(struct regulator_dev *rdev, > > unsigned long event, void *data) > > { > > + const char *name; > > + int ret; > > + > > /* call rdev chain first */ > > - return blocking_notifier_call_chain(&rdev->notifier, event, data); > > + ret = blocking_notifier_call_chain(&rdev->notifier, event, data); > > + > > + if (event & REGULATOR_EVENT_VOLTAGE_CHANGE) { > > + name = dev_attr_microvolts.attr.name; > > + sysfs_notify(&rdev->dev.kobj, NULL, name); > > + } else { > > + name = dev_attr_status.attr.name; > > + sysfs_notify(&rdev->dev.kobj, NULL, name); > > + } > > We probably should filter the events more, there's events for pre and > post voltage change for example which aren't status changes so would be > spurious. It ought not to break anything but we should still avoid > unneeded work. Can you please provide me inputs on the additional filtering needed for this. Like some list of events for notify on status?
| |