lkml.org 
[lkml]   [2023]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    SubjectFwd: [PATCH] firmware: arm_scmi: Remove inappropriate error log.
    ---------- Forwarded message ---------
    发件人: xinglong.yang <seanyang230@gmail.com>
    Date: 2023年11月1日周三 16:17
    Subject: [PATCH] firmware: arm_scmi: Remove inappropriate error log.
    To: <xinglong.yang@cixtech.com>, <sudeep.holla@arm.com>,
    <cristian.marussi@arm.com>
    Cc: <linux-arm-kernel@lists.infradead.org>


    The platform may not support fastchannel, but this is a legal
    operation.

    -Before this patch, when the platform not support fastchannel,
    goto err_xfer will print "Failed to ...". This log is misleading.

    -With this patch, when the fastchannel is not been supported,
    the "Failed to ..." log will be skipped.

    Signed-off-by: xinglong.yang <xinglong.yang@cixtech.com>
    ---
    drivers/firmware/arm_scmi/driver.c | 6 +++++-
    1 file changed, 5 insertions(+), 1 deletion(-)

    diff --git a/drivers/firmware/arm_scmi/driver.c
    b/drivers/firmware/arm_scmi/driver.c
    index b5957cc12fee..2b990e50c8a5 100644
    --- a/drivers/firmware/arm_scmi/driver.c
    +++ b/drivers/firmware/arm_scmi/driver.c
    @@ -1642,7 +1642,10 @@ scmi_common_fastchannel_init(const struct
    scmi_protocol_handle *ph,
    * fastchannels at all.
    */
    ret = ph->xops->do_xfer(ph, t);
    - if (ret)
    + if (ret == -EOPNOTSUPP) {
    + ph->xops->xfer_put(ph, t);
    + goto return_normal;
    + } else if (ret)
    goto err_xfer;

    resp = t->rx.buf;
    @@ -1695,6 +1698,7 @@ scmi_common_fastchannel_init(const struct
    scmi_protocol_handle *ph,
    "Using valid FC for protocol %X [MSG_ID:%u / RES_ID:%u]\n",
    pi->proto->id, message_id, domain);

    +return_normal:
    return;

    err_db_mem:
    --
    2.42.0
    \
     
     \ /
      Last update: 2023-11-02 10:56    [W:2.908 / U:0.072 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site