Messages in this thread | | | Date | Sat, 18 Nov 2023 18:45:49 +0700 | Subject | Re: [PATCH] power: supply: Fix indentation and some other warnings | From | Bagas Sanjaya <> |
| |
On 11/18/23 17:36, Charalampos Mitrodimas wrote: > Hi Bagas, > > On Sat Nov 18, 2023 at 1:36 AM EET, Bagas Sanjaya wrote: >> On Fri, Nov 17, 2023 at 11:06:58PM +0000, Charalampos Mitrodimas wrote: >>> These were mentioned by checkpatch: >>> Errors: >>> (1) code indent should use tabs where possible >>> (2) switch and case should be at the same indent >>> Warnings: >>> (1) quoted string split across lines >>> (2) Missing a blank line after declarations >>> >>> Based on this comment from "include/linux/module.h", modules with >>> multiple authors should use multiple MODULE_AUTHOR() statements. >>> /* >>> * Author(s), use "Name <email>" or just "Name", for multiple >>> * authors use multiple MODULE_AUTHOR() statements/lines. >>> */ >>> #define MODULE_AUTHOR(_author) MODULE_INFO(author, _author) >> >> Shouldn't MODULE_AUTHOR fix be separate patch? > > Sorry, I should have mentioned in the commit that the warnings "quoted > string split across lines" pertained to the MODULE_AUTHOR line. > > In the commit message I'm just clarifying why I used multiple > MODULE_AUTHOR statements. > > Should I send a v2 patch with a revised commit description? >
OK but as separate patch.
-- An old man doll... just what I always wanted! - Clara
| |