Messages in this thread | | | From | Andy Shevchenko <> | Date | Sat, 18 Nov 2023 18:46:45 +0200 | Subject | Re: [PATCH v3 04/11] leds: aw200xx: calculate dts property display_rows in the driver |
| |
On Wed, Nov 1, 2023 at 4:24 PM Dmitry Rokosov <ddrokosov@salutedevices.com> wrote: > > From: George Stark <gnstark@salutedevices.com> > > Get rid of device tree property "awinic,display-rows". The property > value actually means number of current switches and depends on how leds > are connected to the device. It should be calculated manually by max > used led number. In the same way it is computed automatically now. > Max used led is taken from led definition subnodes.
...
> +static bool aw200xx_probe_get_display_rows(struct device *dev, struct aw200xx *chip) > +{ > + struct fwnode_handle *child; > + u32 max_source = 0; > + > + device_for_each_child_node(dev, child) { > + u32 source; > + int ret; > + > + ret = fwnode_property_read_u32(child, "reg", &source); > + if (ret || source >= chip->cdef->channels) > + continue; > + > + max_source = max(max_source, source); > + }
> + chip->display_rows = max_source / chip->cdef->display_size_columns + 1; > + return !!chip->display_rows;
This is a bit weird. Can we rewrite it as
if (max_source == 0) return false;
->display_rows = ... return true;
?
> +}
-- With Best Regards, Andy Shevchenko
| |