lkml.org 
[lkml]   [2023]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH v2 09/15] staging: vc04_services: Add helpers for vchiq driver data
    From
    Hi Umang,

    Am 09.11.23 um 22:03 schrieb Umang Jain:
    > Add helpers to set and get vchiq driver data.
    > vchiq_set_drvdata() and vchiq_get_drvdata() wraps
    > dev_set_drvdata() and dev_get_drvdata() respectively.

    no strong opinion here, but is this change a real benefit?

    Except of this such a change should make use of it.

    >
    > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
    > ---
    > .../vc04_services/interface/vchiq_arm/vchiq_bus.h | 10 ++++++++++
    > 1 file changed, 10 insertions(+)
    >
    > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.h
    > index caa6fdf25bb1..800f53bb48c2 100644
    > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.h
    > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_bus.h
    > @@ -34,6 +34,16 @@ static inline struct vchiq_driver *to_vchiq_driver(struct device_driver *d)
    > return container_of(d, struct vchiq_driver, driver);
    > }
    >
    > +static inline void *vchiq_get_drvdata(const struct vchiq_device *device)
    > +{
    > + return dev_get_drvdata(&device->dev);
    > +}
    > +
    > +static inline void vchiq_set_drvdata(struct vchiq_device *device, void *data)
    > +{
    > + dev_set_drvdata(&device->dev, data);
    > +}
    > +
    > extern struct bus_type vchiq_bus_type;
    >
    > struct vchiq_device *

    \
     
     \ /
      Last update: 2023-11-20 14:04    [W:5.199 / U:0.028 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site