Messages in this thread | | | From | Fabio Estevam <> | Date | Fri, 17 Nov 2023 16:27:47 -0300 | Subject | Re: [PATCH] drm/rockchip: lvds: do not print error message when deferring probe |
| |
Hi Quentin,
On Fri, Nov 17, 2023 at 3:31 PM Quentin Schulz <foss+kernel@0leil.net> wrote: > > From: Quentin Schulz <quentin.schulz@theobroma-systems.com> > > This scary message may happen if the panel or bridge is not probed > before the LVDS controller is, resulting in some head scratching because > the LVDS panel is actually working, since a later try will eventually > find the panel or bridge. > > Therefore let's demote this error message into a debug message to not > scare users unnecessarily. ...
> diff --git a/drivers/gpu/drm/rockchip/rockchip_lvds.c b/drivers/gpu/drm/rockchip/rockchip_lvds.c > index f0f47e9abf5a..52e2ce2a61a8 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_lvds.c > +++ b/drivers/gpu/drm/rockchip/rockchip_lvds.c > @@ -577,7 +577,7 @@ static int rockchip_lvds_bind(struct device *dev, struct device *master, > ret = -EINVAL; > goto err_put_port; > } else if (ret) { > - DRM_DEV_ERROR(dev, "failed to find panel and bridge node\n"); > + DRM_DEV_DEBUG(dev, "failed to find panel and bridge node\n"); > ret = -EPROBE_DEFER;
What about using dev_err_probe() instead?
| |