lkml.org 
[lkml]   [2023]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] cpufreq: scmi: process the result of devm_of_clk_add_hw_provider()
    Date
    devm_of_clk_add_hw_provider() may return an errno, so
    add a return value check

    Found by Linux Verification Center (linuxtesting.org) with SVACE.

    Fixes: 8410e7f3b31e ("cpufreq: scmi: Fix OPP addition failure with a dummy clock provider")
    Signed-off-by: Alexandra Diupina <adiupina@astralinux.ru>
    ---
    drivers/cpufreq/scmi-cpufreq.c | 9 +++++++--
    1 file changed, 7 insertions(+), 2 deletions(-)

    diff --git a/drivers/cpufreq/scmi-cpufreq.c b/drivers/cpufreq/scmi-cpufreq.c
    index c8a7ccc42c16..4037945663bf 100644
    --- a/drivers/cpufreq/scmi-cpufreq.c
    +++ b/drivers/cpufreq/scmi-cpufreq.c
    @@ -334,8 +334,13 @@ static int scmi_cpufreq_probe(struct scmi_device *sdev)

    #ifdef CONFIG_COMMON_CLK
    /* dummy clock provider as needed by OPP if clocks property is used */
    - if (of_property_present(dev->of_node, "#clock-cells"))
    - devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, NULL);
    + if (of_property_present(dev->of_node, "#clock-cells")) {
    + ret = devm_of_clk_add_hw_provider(dev, of_clk_hw_simple_get, NULL);
    + if (ret) {
    + dev_err(dev, "%s: registering clock provider failed, err: %d\n",
    + __func__, ret);
    + }
    + }
    #endif

    ret = cpufreq_register_driver(&scmi_cpufreq_driver);
    --
    2.30.2
    \
     
     \ /
      Last update: 2023-11-20 14:02    [W:7.003 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site