lkml.org 
[lkml]   [2023]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 9/9] dt-bindings: net: ipq4019-mdio: Document ipq5332 platform
    From


    On 11/17/2023 6:40 PM, Krzysztof Kozlowski wrote:
    > On 17/11/2023 11:36, Jie Luo wrote:
    >>>> clocks:
    >>>> - items:
    >>>> - - description: MDIO clock source frequency fixed to 100MHZ
    >>>> + minItems: 1
    >>>> + maxItems: 5
    >>>> + description:
    >>>
    >>> Doesn't this make all other variants with incorrect constraints?
    >>
    >> There are 5 clock items, the first one is the legacy MDIO clock, the
    >> other clocks are new added for ipq5332 platform, will describe it more
    >> clearly in the next patch set.
    >
    > OTHER variants. Not this one.

    The change here is for the clock number added for the ipq5332 platform,
    the other platforms still use only legacy MDIO clock.

    so i add minItems and maxItems, i will check other .yaml files for the
    reference.

    >
    >>
    >>>
    >>>> + MDIO system clock frequency fixed to 100MHZ, and the GCC uniphy
    >>>> + clocks enabled for resetting ethernet PHY.
    >>>>
    >>>> clock-names:
    >>>> - items:
    >>>> - - const: gcc_mdio_ahb_clk
    >>>> + minItems: 1
    >>>> + maxItems: 5
    >>>> +
    >>>> + phy-reset-gpio:
    >>>
    >>> No, for multiple reasons. It's gpios first of all. Where do you see such
    >>> property? Where is the existing definition?
    >>
    >> will remove this property, and update to use the exited PHY GPIO reset.
    >>
    >>>
    >>> Then it is "reset-gpios" if this is MDIO. Why do you put phy properties
    >>> in MDIO?
    >>>
    >>>> + minItems: 1
    >>>> + maxItems: 3
    >>>> + description:
    >>>> + GPIO used to reset the PHY, each GPIO is for resetting the connected
    >>>> + ethernet PHY device.
    >>>> +
    >>>> + phyaddr-fixup:
    >>>> + description: Register address for programing MDIO address of PHY devices
    >>>
    >>> You did not test code which you sent.
    >>
    >> Hi Krzysztof,
    >> This patch is passed with the following command in my workspace.
    >> i will upgrade and install yamllint to make sure there is no
    >> warning reported anymore.
    >>
    >> make dt_bg_check
    >
    > No clue what's this, but no, I do not believe you tested it at all. It's
    > not about yamllint. It's was not tested. Look at errors reported on
    > mailing list.
    >
    >> DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
    >

    Hi Krzysztof,
    Here is the output when i run the dt check with this patch applied in my
    workspace, md64 is the alias for compiling the arm64 platform.

    md64 dt_binding_check
    DT_SCHEMA_FILES=Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.yaml
    warning: python package 'yamllint' not installed, skipping
    CHKDT Documentation/devicetree/bindings/processed-schema.json
    SCHEMA Documentation/devicetree/bindings/processed-schema.json
    DTEX
    Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.example.dts
    DTC_CHK
    Documentation/devicetree/bindings/net/qcom,ipq4019-mdio.example.dtb


    >
    > Best regards,
    > Krzysztof
    >

    \
     
     \ /
      Last update: 2023-11-20 14:02    [W:3.450 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site