lkml.org 
[lkml]   [2023]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [EXT] Re: [net PATCH] octeontx2-pf: Fix memory leak during interface down
Date
>Hi Suman,
>
>I'm wondering if the fixes tag should refer to the commit that introduced
>the allocation that your patch is freeing.
[Suman] Yes, that make sense. I will update in v2.
>
>Fixes: 81a4362016e7 ("octeontx2-pf: Add RSS multi group support")
>
>> ---
>> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>> index 91b99fd70361..ba95ac913274 100644
>> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c
>> @@ -1934,6 +1934,8 @@ int otx2_stop(struct net_device *netdev)
>> /* Clear RSS enable flag */
>> rss = &pf->hw.rss_info;
>> rss->enable = false;
>> + if (!netif_is_rxfh_configured(netdev))
>> + kfree(rss->rss_ctx[DEFAULT_RSS_CONTEXT_GROUP]);
>>
>> /* Cleanup Queue IRQ */
>> vec = pci_irq_vector(pf->pdev,
>> --
>> 2.25.1
>>

\
 
 \ /
  Last update: 2023-11-20 14:02    [W:0.093 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site