Messages in this thread | | | From | Suman Ghosh <> | Subject | RE: [EXT] Re: [net PATCH] octeontx2-pf: Fix memory leak during interface down | Date | Fri, 17 Nov 2023 10:25:23 +0000 |
| |
>Hi Suman, > >I'm wondering if the fixes tag should refer to the commit that introduced >the allocation that your patch is freeing. [Suman] Yes, that make sense. I will update in v2. > >Fixes: 81a4362016e7 ("octeontx2-pf: Add RSS multi group support") > >> --- >> drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c >> b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c >> index 91b99fd70361..ba95ac913274 100644 >> --- a/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c >> +++ b/drivers/net/ethernet/marvell/octeontx2/nic/otx2_pf.c >> @@ -1934,6 +1934,8 @@ int otx2_stop(struct net_device *netdev) >> /* Clear RSS enable flag */ >> rss = &pf->hw.rss_info; >> rss->enable = false; >> + if (!netif_is_rxfh_configured(netdev)) >> + kfree(rss->rss_ctx[DEFAULT_RSS_CONTEXT_GROUP]); >> >> /* Cleanup Queue IRQ */ >> vec = pci_irq_vector(pf->pdev, >> -- >> 2.25.1 >>
| |