lkml.org 
[lkml]   [2023]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 2/6] irqchip: Add interrupt controller support for Realtek DHC SoCs
Date

>>So you update the effective affinity even if it cannot be set or if the
>>parent irq returns an error code?
>>
>>Aside of that setting it to cpu_online mask is just wrong. This is
>>_NOT_ the effective affinity because the underlying GIC selects a
>>single target CPU out of the caller provides cpu mask.
>>
>>That said, this is also completely inconsistent vs. the other
>>interrupts which share that GIC interrupt instance. I.e.
>>/proc/irq/$N/affinity and effective_affinity become random number generators.
>That'll confuse existing userspace tools.
>>
>>Having an affinity setter for demultiplexes interrupts is simply wrong.
>>
>I will use the 'irq_chip_set_affinity_parent' replace the
>'realtek_intc_set_affinity'.

I will remove the capability to set CPU affinity.

Regards,
James


\
 
 \ /
  Last update: 2023-11-20 14:02    [W:0.049 / U:2.476 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site