Messages in this thread | | | Date | Fri, 17 Nov 2023 17:44:08 +0800 | Subject | Re: [PATCH v4 2/6] dt-bindings: net: ethernet-controller: add 10g-qxgmii mode | From | Jie Luo <> |
| |
On 11/16/2023 10:22 PM, Conor Dooley wrote: > On Thu, Nov 16, 2023 at 07:24:33PM +0800, Luo Jie wrote: >> Add the new interface mode 10g-qxgmii, which is similar to >> usxgmii but extend to 4 channels to support maximum of 4 >> ports with the link speed 10M/100M/1G/2.5G. >> > >> This patch is separated from Vladimir Oltean's previous patch >> <net: phy: introduce core support for phy-mode = "10g-qxgmii">. > > This belongs in the changelog under the --- line.
will move out these two lines.
> >> >> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> > > Are you missing a from: line in this patch?
will modify the author in the next patch set.
> >> Signed-off-by: Luo Jie <quic_luoj@quicinc.com> > > Otherwise, > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Cheers, > Conor. > >> --- >> Documentation/devicetree/bindings/net/ethernet-controller.yaml | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/Documentation/devicetree/bindings/net/ethernet-controller.yaml b/Documentation/devicetree/bindings/net/ethernet-controller.yaml >> index d14d123ad7a0..0ef6103c5fd8 100644 >> --- a/Documentation/devicetree/bindings/net/ethernet-controller.yaml >> +++ b/Documentation/devicetree/bindings/net/ethernet-controller.yaml >> @@ -104,6 +104,7 @@ properties: >> - usxgmii >> - 10gbase-r >> - 25gbase-r >> + - 10g-qxgmii >> >> phy-mode: >> $ref: "#/properties/phy-connection-type" >> -- >> 2.42.0 >>
| |