Messages in this thread | | | Subject | Re: [GIT PULL] perf tools changes for v6.7 | From | Yang Jihong <> | Date | Sat, 18 Nov 2023 10:59:26 +0800 |
| |
Hello,
On 2023/11/14 3:28, Daniel Díaz wrote: > Hello! > > On Thu, 2 Nov 2023 at 09:06, Namhyung Kim <namhyung@kernel.org> wrote: >> Hi Linus, >> >> Please consider pulling the latest perf tools changes. >> >> Thanks, >> Namhyung > [...] >> Yang Jihong (29): >> perf evlist: Add perf_evlist__go_system_wide() helper >> perf evlist: Add evlist__findnew_tracking_event() helper >> perf record: Move setting tracking events before record__init_thread_masks() >> perf record: Track sideband events for all CPUs when tracing selected CPUs >> perf test: Add test case for record sideband events >> perf test: Add perf_event_attr test for record dummy event >> perf kwork: Fix incorrect and missing free atom in work_push_atom() >> perf kwork: Add the supported subcommands to the document >> perf kwork: Set ordered_events to true in 'struct perf_tool' >> perf kwork: Add `kwork` and `src_type` to work_init() for 'struct kwork_class' >> perf kwork: Overwrite original atom in the list when a new atom is pushed. >> perf kwork: Set default events list if not specified in setup_event_list() >> perf kwork: Add sched record support >> perf kwork: Add `root` parameter to work_sort() >> perf kwork top: Introduce new top utility > [...] > > We have found some build regressions on yesterday's 6.7-rc1: > -----8<----- > builtin-kwork.c: In function 'top_print_work': > builtin-kwork.c:1646:28: error: format '%ld' expects argument of > type 'long int', but argument 3 has type 'u64' {aka 'long long > unsigned int'} [-Werror=format=] > 1646 | ret += printf(" %*ld ", PRINT_PID_WIDTH, work->id); > | ~~~^ ~~~~~~~~ > | | | > | long int u64 > {aka long long unsigned int} > | %*lld > cc1: all warnings being treated as errors > make[3]: *** [/builds/linux/tools/build/Makefile.build:106: > /home/tuxbuild/.cache/tuxmake/builds/1/build/builtin-kwork.o] Error 1 > ----->8----- > > This is when building for Arm (32-bits) and i386. Bisection points to > commit 55c40e505234 ("perf kwork top: Introduce new top utility"). > > Reported-by: Linux Kernel Functional Testing <lkft@linaro.org> > > To reproduce locally, > tuxmake \ > --runtime podman \ > --target-arch arm \ > --toolchain gcc-13 \ > --kconfig https://storage.tuxsuite.com/public/linaro/lkft/builds/2Y6I5Blgre1fELnAgUTZxqjByvv/config > \ > debugkernel dtbs dtbs-legacy headers kernel modules perf > > Greetings! > Thanks for informing of build error, has send fix patch for it: https://lore.kernel.org/all/20231118024858.1567039-2-yangjihong1@huawei.com/
Thanks, Yang .
| |