Messages in this thread | | | From | Heiko Stuebner <> | Subject | Re: [PATCH] docs: dt-bindings: add DTS Coding Style document | Date | Thu, 16 Nov 2023 20:26:41 +0100 |
| |
Hi Krzysztof, Am Donnerstag, 16. November 2023, 19:12:18 CET schrieb Krzysztof Kozlowski: > Document preferred coding style for Devicetree sources (DTS and DTSI), > to bring consistency among all (sub)architectures and ease in reviews. > > Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > Cc: Arnd Bergmann <arnd@arndb.de> > Cc: Bjorn Andersson <andersson@kernel.org> > Cc: Geert Uytterhoeven <geert+renesas@glider.be> > Cc: Heiko Stuebner <heiko@sntech.de> > Cc: Konrad Dybcio <konrad.dybcio@linaro.org> > Cc: Matthias Brugger <matthias.bgg@gmail.com> > Cc: Michal Simek <michal.simek@amd.com> > Cc: Neil Armstrong <neil.armstrong@linaro.org> > Cc: Nishanth Menon <nm@ti.com> > Cc: Olof Johansson <olof@lixom.net> > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >
> +Order of Properties in Device Node > +---------------------------------- > + > +Following order of properties in device nodes is preferred: > + > +1. compatible > +2. reg > +3. ranges > +4. All properties with values > +5. Boolean properties
I guess the only thing I do have questions about is the part
> +4. All properties with values > +5. Boolean properties
Is there a rationale for it? Because with it things like regulator-* properties then end up in two different blocks.
For all the rest I fully agree :-)
Thanks Heiko
> +6. status (if applicable) > +7. Child nodes > + > +The "status" property is by default "okay", thus it can be omitted. > + > +Example:: > + > + // SoC DTSI > + > + usb_1_hsphy: phy@88e3000 { > + compatible = "qcom,sm8550-snps-eusb2-phy"; > + reg = <0x0 0x088e3000 0x0 0x154>; > + #phy-cells = <0>; > + resets = <&gcc GCC_QUSB2PHY_PRIM_BCR>; > + status = "disabled"; > + }; > + > + // Board DTS > + > + &usb_1_hsphy { > + clocks = <&tcsr TCSR_USB2_CLKREF_EN>; > + clock-names = "ref"; > + status = "okay"; > + }; > +
| |