Messages in this thread | | | From | "Romanowski, Rafal" <> | Subject | RE: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking fields from iavf_adminq_ring | Date | Thu, 16 Nov 2023 15:52:06 +0000 |
| |
> -----Original Message----- > From: Intel-wired-lan <intel-wired-lan-bounces@osuosl.org> On Behalf Of > Simon Horman > Sent: Friday, November 3, 2023 6:09 PM > To: ivecera <ivecera@redhat.com> > Cc: Drewek, Wojciech <wojciech.drewek@intel.com>; > netdev@vger.kernel.org; Brandeburg, Jesse <jesse.brandeburg@intel.com>; > linux-kernel@vger.kernel.org; Eric Dumazet <edumazet@google.com>; > Nguyen, Anthony L <anthony.l.nguyen@intel.com>; intel-wired- > lan@lists.osuosl.org; Keller, Jacob E <jacob.e.keller@intel.com>; Jakub Kicinski > <kuba@kernel.org>; Paolo Abeni <pabeni@redhat.com>; David S. Miller > <davem@davemloft.net> > Subject: Re: [Intel-wired-lan] [PATCH iwl-next] iavf: Remove queue tracking > fields from iavf_adminq_ring > > On Thu, Oct 26, 2023 at 10:39:32AM +0200, Ivan Vecera wrote: > > Fields 'head', 'tail', 'len', 'bah' and 'bal' in iavf_adminq_ring are > > used to store register offsets. These offsets are initialized and > > remains constant so there is no need to store them in the > > iavf_adminq_ring structure. > > > > Remove these fields from iavf_adminq_ring and use register offset > > constants instead. Remove iavf_adminq_init_regs() that originally > > stores these constants into these fields. > > > > Finally improve iavf_check_asq_alive() that assumes that non-zero > > value of hw->aq.asq.len indicates fully initialized AdminQ send queue. > > Replace it by check for non-zero value of field hw->aq.asq.count that > > is non-zero when the sending queue is initialized and is zeroed during > > shutdown of the queue. > > > > Signed-off-by: Ivan Vecera <ivecera@redhat.com> > > Thanks, this is a nice cleanup. > > Reviewed-by: Simon Horman <horms@kernel.org> > > ... > _______________________________________________ > Intel-wired-lan mailing list > Intel-wired-lan@osuosl.org > https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Tested-by: Rafal Romanowski <rafal.romanowski@intel.com>
| |