Messages in this thread | | | From | James Tai [戴志峰] <> | Subject | RE: [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver | Date | Thu, 16 Nov 2023 15:29:25 +0000 |
| |
Hi Thomas,
>> +enum rtd1319_iso_isr_bits { >> + RTD1319_ISO_ISR_TC3_SHIFT = 1, >> + RTD1319_ISO_ISR_UR0_SHIFT = 2, > >Please use tabular formatting all over the place.
I will fix it in the next patches.
> >> + RTD1319_ISO_ISR_LSADC0_SHIFT = 3, >> + RTD1319_ISO_ISR_IRDA_SHIFT = 5, >> + > > >> +static const struct realtek_intc_info rtd1319_intc_iso_info = { >> + .isr_offset = 0x0, >> + .umsk_isr_offset = 0x4, >> + .scpu_int_en_offset = 0x40, > >Magic numbers. Defines exist for a reason.
I will fix it in the next patches.
Thank you for your feedback.
Regards, James
| |