lkml.org 
[lkml]   [2023]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH 3/6] irqchip: Introduce RTD1319 support using the Realtek Common Interrupt Controller Driver
Date
Hi Thomas,

>> +enum rtd1319_iso_isr_bits {
>> + RTD1319_ISO_ISR_TC3_SHIFT = 1,
>> + RTD1319_ISO_ISR_UR0_SHIFT = 2,
>
>Please use tabular formatting all over the place.

I will fix it in the next patches.

>
>> + RTD1319_ISO_ISR_LSADC0_SHIFT = 3,
>> + RTD1319_ISO_ISR_IRDA_SHIFT = 5,
>> +
>
>
>> +static const struct realtek_intc_info rtd1319_intc_iso_info = {
>> + .isr_offset = 0x0,
>> + .umsk_isr_offset = 0x4,
>> + .scpu_int_en_offset = 0x40,
>
>Magic numbers. Defines exist for a reason.

I will fix it in the next patches.

Thank you for your feedback.

Regards,
James


\
 
 \ /
  Last update: 2023-11-20 14:01    [W:0.224 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site